-
-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed & Imporoved AxiosHeaders class #5224
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I need this badly. Can this be approved please? |
Also watching for the merge of this! |
This was referenced Nov 5, 2022
Can a release be issued for this? |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is just a copy of #5169 that was closed automatically by mistake due to referencing from another PR)
This PR has potential breaking changes in AxiosHeaders class.
defaultHeaders
);concat
method to merge headers into a new instance. This is a functional replacement to merge with defaults externally. This change greatly simplifies the implementation and makes class usage more transparent.set
method (as well as the class constructor) now accepts aAxiosHeaders
instance and raw headers string as the sourcetoString
to serialize into a raw headers stringundefined
, notapplication/x-www-form-urlencoded
. This step makes it easier to keep track of user-defined header values, simplifying the implementation of the AxiosHeaders class. However, the content header will still be added before the request is sent if it is not explicitly defined or disabled by the user. Only the place and method of adding this header inside the Axios have been changed.Closes #5157;
Closes #5067;
Closes #5006;
Closes #5226;
Closes #4998;